Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Regional collections #1479

Merged
merged 7 commits into from
Jun 8, 2016
Merged

Regional collections #1479

merged 7 commits into from
Jun 8, 2016

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Jun 8, 2016 •
edited
Loading

Fixes #1476 by turning states (California), offshore regions ("Gulf of Mexico"), and offshore areas ("Central Gulf of Mexico") into Jekyll collections.

😎 PREVIEW

Changes proposed in this pull request:

  • Instead of using this plugin, there is now states collection that is used to generate one page per state.
    • This resolves the issue of the state pages having titles like UT instead of Utah 🎉
  • There's also an offshore_regions collection that contains our for offshore regions: Alaska, Atlantic, Gulf of Mexico, and Pacific. These can eventually have URLs of their own, but I've disabled the output option for now.
  • Offshore areas (the next level down from regions, so the equivalent of counties) have a collection, and can also be given URLs of their own when we're ready. The permalink for each of these pages will put them under their offshore region path, e.g. /offshore/gulf/CGM/ for Central Gulf of Mexico.

/cc @gemfarmer

@shawnbot
Copy link
Contributor Author

shawnbot commented Jun 8, 2016

Unfortunately, this doesn't appear to reduce the build times at all. 😢

@shawnbot shawnbot mentioned this pull request Jun 8, 2016
Closed
@shawnbot
Copy link
Contributor Author

shawnbot commented Jun 8, 2016

Actually, I think it did reduce build times, at least a little bit. I'm seeing ~5s build times when I modify files in the _states directory.

@gemfarmer
Copy link
Contributor

WOO! This is awesome. to-jekyll-collections is also pretty slick. I could see that being useful for other projects with cumbersome collections

@gemfarmer
Copy link
Contributor

gemfarmer commented Jun 8, 2016 •
edited
Loading

@shawnbot this looks great, but I'm not seeing great load times. Mine have spiked to the 20-30 second range.

@shawnbot nvm the above comment. The load times are good. I was using Google Hangouts and it was causing the slow times.

@gemfarmer gemfarmer merged commit 9299ab8 into state-pages Jun 8, 2016
@gemfarmer
Copy link
Contributor

This is so awesome! 🎉 🎉 MERGED!

@gemfarmer gemfarmer deleted the regional-collections branch June 8, 2016 22:26
@shawnbot
Copy link
Contributor Author

shawnbot commented Jun 8, 2016

Hmmm. @gemfarmer are you running bundle exec jekyll serve --incremental (or npm start)?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnbot @gemfarmer